Multipacket handling for credentials listing and other improvements #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szszszsz
force-pushed
the
state-encryption-smaller-buffer
branch
from
5df4632
to
9580018
Compare
Load tests counters: 425 RW before, 421 RO / 4 RW now
Handle injected key writing error Show error on failed write
Abort if the previous state is not set. Try to clean up after Credential's write failure. Using 0x61FF, as we do not know the count of the remaining bytes.
Fill the buffer as long as it is possible, break otherwise. Instead of using a temporary buffer for the unfit data, reiterate over directories again - this saves memory at the cost of the additional computation.
szszszsz
force-pushed
the
state-encryption-smaller-buffer
branch
2 times, most recently
from
1631dfd
to
314f8e5
Compare
szszszsz
force-pushed
the
state-encryption-smaller-buffer
branch
from
314f8e5
to
98c8b01
Compare
szszszsz
changed the title
|
@robin-nitrokey Friendly ping! |
robin-nitrokey
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
LGTM! I’m not sure if I understand the role of the SendRemaining command though. Currently it has the same effect as calling ListCredentials (unless there is no cached state), right? Wouldn’t it make more sense if ListCredentials would start at zero and only SendRemaining would use the cached state? Alternatively, an optional offset could be added to ListCredentials directly.
|
Regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #19
Fixes #14