Support new memory instructions and native alignment #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Sherstennikov <[email protected]>
All frontend fixes related to 256-bit alignment were removed. The main components affected by the new aligment: - Lowering: several nodes require custom lowering due to operands with unsuitable types(not i256). - Stack allocation: it still uses 256-bits slots for spill/fills, but memory for the local data could not be aligned in 256-bits. Thus, it should be taken into account and properly handled by EVMStackAllocation and EVMConvertRegToStack. - MC and Linker: now we can't treat all integers as 256-bits, therefore the MC emitter produces object files with more detailed description of data. Linker in turn supports this new description and support init data, which is not 256-bit aligned now. Also added ability to use `evmone` as a VM for testing. But it has a drawback: it doesn't support precompiled contracts, so test for __evm_builtin_modpow is disabled for a while. Also, due to proper data size and alignment, `memset` function is working correctly now. So it's test was enabled. Signed-off-by: Mikhail Sherstennikov <[email protected]>
|
cc @avm |
makxenov
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All frontend fixes related to 256-bit alignment were removed.
The main components affected by the new aligment:
types(not i256).
the local data could not be aligned in 256-bits. Thus, it should be taken into
account and properly handled by EVMStackAllocation and EVMConvertRegToStack.
emitter produces object files with more detailed description of data. Linker
in turn supports this new description and support init data, which is not
256-bit aligned now.
Also added ability to use
evmoneas a VM for testing. But it has a drawback:it doesn't support precompiled contracts, so test for __evm_builtin_modpow is
disabled for a while.
Also, due to proper data size and alignment,
memsetfunction is workingcorrectly now. So it's test was enabled.