Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced asserts with exceptions so they are thrown at release #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vo-nil
Copy link
Contributor

@vo-nil vo-nil commented Nov 1, 2024

closes #126

@vo-nil vo-nil self-assigned this Nov 1, 2024
@vo-nil vo-nil requested a review from martun November 1, 2024 07:35
@vo-nil vo-nil marked this pull request as ready for review November 1, 2024 07:35
Copy link

github-actions bot commented Nov 1, 2024

Clang Test Results

  153 files  ± 0    153 suites  ±0   12m 31s ⏱️ -1s
3 541 tests + 2  3 535 ✅ + 2  6 💤 ±0  0 ❌ ±0 
3 601 runs   - 97  3 595 ✅  - 97  6 💤 ±0  0 ❌ ±0 

Results for commit dd077f5. ± Comparison against base commit cf681dc.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

Copy link

github-actions bot commented Nov 1, 2024

Gcc Test Results

  153 files  ± 0    153 suites  ±0   14m 26s ⏱️ -2s
3 541 tests + 2  3 535 ✅ + 2  6 💤 ±0  0 ❌ ±0 
3 601 runs   - 97  3 595 ✅  - 97  6 💤 ±0  0 ❌ ±0 

Results for commit dd077f5. ± Comparison against base commit cf681dc.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error checking for marshalling of zk structures
1 participant