feat: add traces reader to proof producer #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokoshn
reviewed
Oct 24, 2024
proof-producer/bin/proof-producer/include/nil/proof-generator/prover.hpp
Show resolved
Hide resolved
proof-producer/bin/proof-producer/include/nil/proof-generator/traces_reader.hpp
Show resolved
Hide resolved
proof-producer/bin/proof-producer/include/nil/proof-generator/traces_reader.hpp
Outdated
Show resolved
Hide resolved
| struct StackOp { | ||
| bool is_read; | ||
| int idx; | ||
| blueprint::zkevm_word_type value; |
There was a problem hiding this comment.
i guess we can keep here executionproofs::Uint256 and make some conversion only when fill assignment table
There was a problem hiding this comment.
Same about another values, i mean no need to do conversion from protobuf types to std::byte.
We convert them if need during filling assignment table.
But make sense keep conversion functions for external usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.