DHCP6: IPv6 Ready Logo test fixes #397
Conversation
Implement USE_MULTICAST Handle server-directed SOL_MAX_RT and INF_MAX_RT values Perform per RFC 8415 for NotOnLink and NoBinding error conditions Don't attempt to renew expired leases Continue sending Info-Request messages until response is received MAX_RC values aligned with RFC definitions
| */ | ||
| if ((state->state == DH6S_RENEW) && | ||
| (ap->prefix_vltime <= state->renew)) | ||
| continue; |
There was a problem hiding this comment.
The comment does not match the code. vltime and renew values don't actually change - when we add an address we adjust the vltime at that point based on the acquisition time vs now time.
This change makes the assumption that RENEW only happens when t1 expires, but that isn't always the case.
So the address could still be valid and therefore should be renewed.
When an address does expire it is removed from the array, unless it's been requested via config.
So what is this code really trying to achieve?
| eloop_timeout_add_sec(ifp->ctx->eloop, | ||
| INF_MAX_RD, dhcp6_failinform, ifp); | ||
| else | ||
| dhcp6_sendinform(ifp); |
There was a problem hiding this comment.
OK, I see what you're trying to fix here. We want to drop through to failinform so we can use the lastlease code, but only on the first failure.
So I think what we need to do is after we have logged the message we want to guard the state timing changes like so
if (state->state == DH6S_INFORM) {
dhcp6_sendinform(ifp);
return;
}
Then we change failinform to do dhcp6_fail(ifp, false) - ie we don't force a drop.
Adjust the code there to handle lastlease for INFORM and we should be good yes?
| state->lerror == D6_STATUS_NOTONLINK) { | ||
| eloop_timeout_delete(ifp->ctx->eloop, NULL, ifp); | ||
| dhcp6_startdiscover(ifp); | ||
| } |
There was a problem hiding this comment.
We are no longer handling the state where we got a reply without an error but it didn't contain any addresses with error codes either.
Implement USE_MULTICAST
Handle server-directed SOL_MAX_RT and INF_MAX_RT values Perform per RFC 8415 for NotOnLink and NoBinding error conditions Don't attempt to renew expired leases
Continue sending Info-Request messages until response is received
MAX_RC values aligned with RFC definitions