Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for engine_getBlobsV1 #7646

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add metrics for engine_getBlobsV1 #7646

merged 3 commits into from
Oct 24, 2024

Conversation

marcindsobczak
Copy link
Contributor

Changes

  • adding metrics about engine_getBlobsV1 - NumberOfRequestedBlobs and NumberOfSentBlobs

Already added to grafana

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@marcindsobczak marcindsobczak merged commit ebce748 into master Oct 24, 2024
84 checks passed
@marcindsobczak marcindsobczak deleted the fix/engine_get_blobs branch October 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcindsobczak @LukaszRozmej