Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Gallery missing rounded corners #272 #284

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

TomaszDziezykNetcentric

Copy link

aem-code-sync bot commented Dec 11, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@TomaszDziezykNetcentric TomaszDziezykNetcentric changed the base branch from main to develop December 11, 2023 08:57
Copy link

aem-code-sync bot commented Dec 11, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/textual-content-with-images PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@cogniSyb cogniSyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in:

I talked to the team about the border radii. Let’s make it 8px for all the items in your list, for all breakpoints to maximize consistency, since I feel the visual impact is minimal […] can all be changed from 12px to 8px on all breakpoints

Could you remove the line in styles.css that sets --border-radius to 12px?

@cogniSyb cogniSyb changed the title Media gallery refactor #272 Media Gallery missing rounded corners #272 Dec 12, 2023
@TomaszDziezykNetcentric
Copy link
Author

Just in:

I talked to the team about the border radii. Let’s make it 8px for all the items in your list, for all breakpoints to maximize consistency, since I feel the visual impact is minimal […] can all be changed from 12px to 8px on all breakpoints

Could you remove the line in styles.css that sets --border-radius to 12px?

Done

@cogniSyb cogniSyb merged commit 0614158 into develop Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Minor - Media Gallery missing rounded corners
4 participants