This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
BUG FIXED: all channel members are restored wrong #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG RESOLVED: all channel members were restored in wrong (mostly in last) channel, due to over-written value of 'name' - because for loop runs fast and callback (in "load" function) gets the value of 'name' wrong.
shudingbo
added a commit
to sex-pomelo/sex-pomelo
that referenced
this pull request
Nov 15, 2018
1 .NetEase#968 all channel members are restored wrong 2. config/servers.json里的server配置支持clientHost属性 NetEase#935 NetEase#935 3. superfluous code NetEase#743 NetEase#743 4. fix auto-restart option when server has arguments NetEase#912 NetEase#912 5. 修复连接数达到max-connections后，connection计数多1的bug NetEase#896 NetEase#896 6. Updating engine.io configuration methods. NetEase#957 NetEase#957 7. 缺省路由不使用CRC（删除CRC依赖），直接根据 uid 或者 随机 判断（如果uid是数字直接取模，否则随机一个数取模） 8. 在 lifecycle::beforeStartup 里增加 的 yz_autoStartHandler 变量控制service是否在启动时加载，而不是懒加载
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG RESOLVED:
all channel members were restored in wrong (mostly in last) channel,
due to over-written value of 'name'
We were working with 'restoring channels data' from DB after server restarts (after unexpected crash).
and We found that members were added to wrong channel(s).