NHSU CR-302 MIS BLOCKER EMAIL VALIDATOR OF ENTIRE EHCS #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings TWIMC!
On behalf of Ukrainian State Enterprise "Elektronne Zdorovya" I want to inform you can EMAIL validator presented in this package is used in @edenlablcc/schemata EHCS dependency in core application. The CR-302 ticket is a blocker for Ukrainian Medical Information Systems to register email that has gTLD more that 3 letters which is not only violation of RFC 822 but also naive and improper.
The problem is that EHCS is built up based on HEX.PM dependency in
schemata
:You either should accept the following change:
in
lib/ex_json_schema/validator/format.ex
.But overall the
https://hex.pm/packages/nex_json_schema
packages should be replaced withhttps://hex.pm/packages/nex_json_schema2
that hosts on NHSU Github. The duplicated message as separate merge will be requested atedenlabllc/schemata
repository: