Re-add cleanup code from DisposeValue #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-introduces a bunch of Caches cleanup from the ObjectManager, which may improve the situation with leaks to some degree. More work is needed here.
caitp
commented
Aug 25, 2023
| StructWrapper::~StructWrapper() { | ||
| parent_.Reset(); | ||
| if (data_) { | ||
| // v8::Isolate::GetCurrent() may not necessarily be the isolate this object lives in. |
There was a problem hiding this comment.
(but I sure hope it is.. I mean really, it should be.. if it's not, that seems like a v8-cppgc bug?)
|
This needs to be tested against larger projects - it appears to work against the ultimate tab app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-introduces a bunch of Caches cleanup from the ObjectManager, which may improve the situation with leaks to some degree. More work is (probably) needed here.
To be honest, I've only verified that these are passing the in-tree tests, have not tried it against a large application that would see problems from the eternal objects held by the Caches.