fix: don't suppress timer exceptions

NativeScript · Aug 4, 2023 · 0c4b819 · 0c4b819
1 parent 0de1cc3
commit 0c4b819
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/NativeScript/runtime/Timers.cpp b/NativeScript/runtime/Timers.cpp
@@ -161,7 +161,6 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
     v8::Local<v8::Function> cb = task->callback_.Get(isolate);
     v8::Local<v8::Context> context = cb->GetCreationContextChecked();
     Context::Scope context_scope(context);
-    TryCatch tc(isolate);
     auto argc = task->args_.get() == nullptr ? 0 : task->args_->size();
     if (argc > 0) {
         Local<Value> argv[argc];
@@ -172,11 +171,11 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
     } else {
         (void)cb->Call(context, context->Global(), 0, nullptr);
     }
-    tc.ReThrow();
 
     if (!task->repeats_) {
         data->state->removeTask(task);
     }
+
 }
 
 void Timers::SetTimer(const v8::FunctionCallbackInfo<v8::Value>& args, bool repeatable) {