Simplify Transpilation of $ with Extended Line Separator Support in cuDF Regex #11663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11554
In cuDF, support for multiple newline characters was expanded from NEW_LINE (
\n
) to include the following:\u0085
)\u2028
)\u2029
)\r
)\n
)PR #17139 introduced this change to cuDf JNI with
RegexFlag::EXT_LINE
. This PR simplifies the transpilation of$
by changing the pattern from(?:\r|\u0085|\u2028|\u2029|\r\n)?$
to the simpler(?:\r\n)?$
and updates all functions to useRegexFlag::EXT_LINE
wherever this transpilation occurs.This PR also drops support for
$\z
because\z
is not supported by cuDf. Alternatively, we could transpile$\z
to$(?![\r\n\u0085\u2028\u2029])
. However, cuDf doesn't support negative look ahead.