Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error due to changing the signature of cudf Table.readJSON #11655

Draft
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from
Draft

Fix build error due to changing the signature of cudf Table.readJSON #11655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ object JsonPartitionReader {
withResource(new NvtxWithMetrics(formatName + " decode",
NvtxColor.DARK_GREEN, decodeTime)) { _ =>
try {
Table.readJSON(cudfSchema, jsonOpts, dataBuffer, 0, dataSize, dataBufferer.getNumLines)
Table.readJSON(cudfSchema, jsonOpts, dataBuffer, 0, dataSize)
} catch {
case e: AssertionError if e.getMessage == "CudfColumns can't be null or empty" =>
// this happens when every row in a JSON file is invalid (or we are
Expand Down
4 changes: 1 addition & 3 deletions sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonToStructs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ case class GpuJsonToStructs(
// Step 3: Have cudf parse the JSON data
try {
cudf.Table.readJSON(cudfSchema,
jsonOptionBuilder.withLineDelimiter(concatenated.delimiter).build(),
ds,
numRows)
jsonOptionBuilder.withLineDelimiter(concatenated.delimiter).build(), ds)
} catch {
case e: RuntimeException =>
throw new JsonParsingException("Currently some JsonToStructs cases " +
Expand Down