-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform conversion for the columns output from Table.readJSON
to other data types using JSONUtils.convertDataTypes()
#11618
Draft
ttnghia
wants to merge
11
commits into
NVIDIA:branch-24.12
Choose a base branch
from
ttnghia:from_json_post_processing
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
feature request
New feature or request
SQL
part of the SQL/Dataframe plugin
performance
A performance related task/issue
P0
Must have for release
task
Work required that improves the product but is not user facing
labels
Oct 17, 2024
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
from_json_post_processing
branch
from
October 18, 2024 18:17
8ec6474
to
692a0cb
Compare
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
This reverts commit b3dcffc.
Signed-off-by: Nghia Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
New feature or request
P0
Must have for release
performance
A performance related task/issue
SQL
part of the SQL/Dataframe plugin
task
Work required that improves the product but is not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the new implemented JNI function
JSONUtils.convertDataTypes()
to convert the columns generated byTable.readJSON
to the desired output types as specified in the schema when executingfrom_json
query. By replacing the Scala code by JNI code, we can avoid a lot of overhead and optimize runtime performance.Contribute to #11560.