Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate default DIST_PROFILE_OPT profile to Maven in buildall #11515

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Sep 27, 2024

This PR fixes buildall script by adding back the line that adds the maven profile to use to build.

fixes #11509

Signed-off-by: Raza Jafri <[email protected]>
@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

@revans2 PTAL

@gerashegalov gerashegalov changed the title Fixed buildall script Propagate default DIST_PROFILE_OPT profile to Maven in buildall Sep 27, 2024
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razajafri razajafri merged commit f87ccb9 into NVIDIA:branch-24.10 Sep 27, 2024
46 checks passed
@razajafri razajafri deleted the SP-11514-buildall branch September 27, 2024 23:59
@sameerz sameerz added the build Related to CI / CD or cleanly building label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] buildall no longer works
3 participants