-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bnb/masked fwp #231
Draft
bnb32
wants to merge
385
commits into
main
Choose a base branch
from
bnb/masked_fwp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bnb/masked fwp #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdates to dc exo training tests
…tory meta class. moved bias correct from ForwardPass, done for each chunk, to ForwardPassStrategy init.
…xoData.split` method.
…dler which invoked log interp. Thus the log interp methods from era_downloader can be removed and LogLinInterpolator can also be removed.
…e dask vs numpy arrays
…old Feature class since we now have `parse_feature` method.
…aHandler, following common signature
… returns type specific handler based on file type
…rent time indices, like for monthly files. also added catch in cacher for weird dimensions that we shouldnt be writing to h5
…e saving to final file name.
…t features. now just repeat over time dimension in the forward pass padding method. this is much more performant for time independent features. this doesnt solve slow down issues with time dependent exo features like sza though.
…oad, for era downloader.
… deriver. typo in solar module.
…orrupted and need to be redownloaded
…se must be determined from the config
…g. u_30m from u_10m and u_100m, with u pressure level array
…ed to era downloader
… Added shape checks in ``test_access.py``
…dataset() which will default to a dask array manager if chunks is specified and load into memory as numpy arrays in chunks is None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to skip chunks in the forward pass routine if all coordinates covered by that chunk are masked. The mask is provided as an additional variable through
file_paths
, where mask is 1 / True if the coordinate should not be included in the forward pass. An example which masks conus except for areas around observation locations is shown below.Mask:
Collected forward pass output: