-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Energy Standards Air Conditioner Data Update #1682
Draft
leijerry888
wants to merge
26
commits into
master
Choose a base branch
from
data_update_99d14b7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,962
−2,783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
changed the title
Building Energy Standards Data Update
Building Energy Standards Air Conditioner Data Update
Feb 9, 2024
…onversion, fix lookup issues.
…dio-standards into data_update_99d14b7
lymereJ
reviewed
Apr 5, 2024
Comment on lines
+370
to
+385
# Convert from IEER to COP (no fan) | ||
# | ||
# @note IEER is a weighted-average efficiency metrics at different load percentages, operataional and environemental conditions | ||
# @note IEER should be modeled by using performance curves that match a targeted efficiency values | ||
# @note This method estimates what a reasonable full load rated EER would be for a targeted IEER value | ||
# @note The regression used in this method is based on a survey of over 1,000 rated AHRI units with IEER ranging from 11.8 to 25.6 | ||
# @todo Implement methods to handle IEER modeling | ||
# | ||
# @param ieer [Double] Energy Efficiency Ratio (EER) | ||
# @return [Double] Coefficient of Performance (COP) | ||
def ieer_to_cop_no_fan(ieer) | ||
eer = 0.0183 * ieer * ieer - 0.4552 * ieer + 13.21 | ||
|
||
return eer_to_cop_no_fan(eer) | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New method to convert an IEER to a COP no fan. Note that this is just to estimate what would a reasonable full load gross COP would be for a specific IEER value. IEER-specific performance curves should then be applied. Copper could be used when it supports IEER rated equipment.
…dio-standards into data_update_99d14b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates have been made to the Building Energy Standards Data repository, see here. This pull request was automatically generated.