-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PeakPeriodSchedulesShift measure #57
Open
joseph-robertson
wants to merge
32
commits into
develop
Choose a base branch
from
geb-appliances-peak-period-shift
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
changed the title
New GEBAppliancesPeakPeriodShift measure
New PeakPeriodSchedulesShift measure
Apr 6, 2023
@joseph-robertson do you still intend for this to be draft, or do we want to get this in upcoming measure release? |
@DavidGoldwasser I believe this should remain draft. We will likely be including this measure in future analyses, and so would assist in additional testing of the measure. |
6 tasks
DavidGoldwasser
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58.
This PR creates a new model measure called PeakPeriodSchedulesShift. Its purpose is to shift schedules based on a defined weekday (or weekday/weekend) peak period. Both ScheduleRuleset and ScheduleFile schedules are supported (i.e., they are subject to modifications).
Arguments:
schedules_peak_period
(str)schedules_peak_period_delay
(int)schedules_peak_period_allow_stacking
(bool)schedules_peak_period_weekdays_only
(bool)schedules_peak_period_schedule_rulesets_names
(str; comma-separated)schedules_peak_period_schedule_files_column_names
(str; comma-separated)Constraints:
Some notes/suggestions after 6/27 meeting:
schedules_peak_period_delay
values? I.e., shift to before the peak period?README.md
with a graphic. Here is an example.Other notes: