-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add customization for revit to openstudio results #134
base: develop
Are you sure you want to change the base?
Conversation
@MatthewSteen I like the idea of having single measure. The new I propose a small modification to make these changes more generally applicable for other use cases.
|
@MatthewSteen I want to add in a test for the new argument option to use units from osw file. Can you proivde a sample OSW file with units. I thought I could generate that from OS App, but it doesn't look like it adds that |
@DavidGoldwasser I'll work on adding a test for the new units choice, which is an |
@MatthewSteen ahh assumed maybe it was in the OSW and then loaded here Or is the only way to populate the units with another runner method. |
@MatthewSteen I didn't get to this last night, but I can review this afternoon. |
@DavidGoldwasser I'm not ready for another review yet. I need to test the measure with the Revit Systems Analysis workflow before it's ready again. After I've done that I'll change this to |
@DavidGoldwasser one of the customizations is in the report.html.erb file, which replaces the distributed javascript library sources with local copies in the If this is ok with you, I'll commit those files and add code to replace the sources. |
@MatthewSteen Yes, I'm fine with change to use local javascript files |
@DavidGoldwasser this is ready for a review. |
@DavidGoldwasser this is ready for review. Test failure looks unrelated. Please add this to 0.10.0 if possible. |
Adds a small customization to the OpenStudio Results measure for Revit's Systems Analysis workflow from https://github.com/NREL/gbxml-to-openstudio/measures to reduce redundancy and establish a single source of truth. When/if this is merged, the duplicate OpenStudio Results measure can be removed from the gbxml-to-openstudio repo.