Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValueCurves from PowerSystems to infrasys #38

Merged
merged 38 commits into from
Aug 15, 2024

Conversation

jerrypotts
Copy link
Collaborator

  • Added classes for InputOutputCurve, IncrementalCurve, and AverageRateCurve that call function_data classes to build generic cost curves. These classes are analogous to the structs found in PowerSystems
  • Added functions to convert between the different value_curves classes (ex: InputOutputToIncremental creates an IncrementalCurve from an existing InputOutputCurve)
  • Added functions to function_data to perform calculations for value_curve conversion
  • Added additional serialization tests to test_function_data

@pesap pesap self-requested a review July 9, 2024 18:26
Copy link
Collaborator

@daniel-thom daniel-thom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a cursory pass and have two minor comments.

src/infrasys/exceptions.py Outdated Show resolved Hide resolved
src/infrasys/function_data.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pesap pesap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you address the changes we can merge it right away.

src/infrasys/production_variable_cost_curve.py Outdated Show resolved Hide resolved
src/infrasys/production_variable_cost_curve.py Outdated Show resolved Hide resolved
src/infrasys/production_variable_cost_curve.py Outdated Show resolved Hide resolved
src/infrasys/value_curves.py Outdated Show resolved Hide resolved
tests/test_production_variable_cost_curve.py Outdated Show resolved Hide resolved
@pesap pesap merged commit db59ea2 into NREL:main Aug 15, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
… to infrasys (#38)

- Added classes for InputOutputCurve, IncrementalCurve, and AverageRateCurve that call function_data classes to build generic cost curves. These classes are analogous to the structs found in PowerSystems
- Added functions to convert between the different value_curves classes (ex: InputOutputToIncremental creates an IncrementalCurve from an existing InputOutputCurve)
- Added functions to function_data to perform calculations for value_curve conversion
- Added additional serialization tests to test_function_data
---------

Co-authored-by: pesap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants