-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for vertical-axis wind turbines #701
Open
vallbog
wants to merge
51
commits into
NREL:develop
Choose a base branch
from
vallbog:feature/VAWT-infrastructure
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @vallbog Sorry for the delay in any response. August and September are very busy months for us, so we haven't had a chance to consider this work. I will be more available to work with you toward the end of September or definitely beginning of October. Thanks for your patience, and thanks for sending this contribution! |
I understand. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure for vertical-axis wind turbines
This is a part of a series of PRs aimed to add support for vertical-axis wind turbines in FLORIS. The development structure is outlined in the next section. This PR makes sure that the velocity at each turbine is sampled correctly for both horizontal-axis wind turbines (HAWTs) and vertical-axis wind turbines (VAWTs). It also makes sure that turbine powers are calculated correctly for VAWTs.
More specifically, the PR includes the following:
TurbineGrid
class: Now supports both HAWTs and VAWTs, including a mix of the two in the same farm. A square grid is used for HAWTs and a rectangular grid is used for VAWTs. The number of grid points in each direction (cross-stream and vertically) may now be different to allow for approximately equidistant grid points in farms with only VAWTs.VerticalAxisTurbine
class: This class is similar to the existingTurbine
class insimulation/turbine.py
. The correct rotor cross-sectional area is now used when calculating the turbine power for a VAWT.30_vertical_axis_turbine.py
: This example was created in Add super-Gaussian velocity model for vertical-axis wind turbines #700 to show a characteristic wake of a VAWT. It now also calculates turbine powers in a layout with tandem VAWTs.tests/reg_tests/super_gaussian_vawt_regression_test.py
Related PRs and branches
The following branch structure shows how several PRs are related:
Links:
Impacted areas of the software
Compared to #700, the main changes are in:
floris/simulation/grid.py
floris/simulation/turbine.py