-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Replacements Treatment #210
base: develop
Are you sure you want to change the base?
Conversation
@@ -344,43 +344,48 @@ function cost_curve(tech::AbstractTech, financial::Financial) | |||
itc_unit_basis = (cap_cost_slope[s] + rebate_federal) / (1 - itc) | |||
end | |||
|
|||
macrs_schedule = [0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added all of this as in-line conditional statements below
@@ -48,7 +48,7 @@ | |||
can_export_beyond_nem_limit = false, | |||
can_curtail::Bool = false, | |||
macrs_option_years::Int = 0, | |||
macrs_bonus_fraction::Real = 1.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we previously defaulted this to 1. It got set to 0 anyway (in cost_curve.jl) since macrs_option_years = 0.
@@ -162,6 +175,63 @@ function effective_cost(; | |||
return round(cap_cost_slope, digits=4) | |||
end | |||
|
|||
function replacement_effective_cost(; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this a separate function so we can just call this to get replacement costs in the reporting of results.
not really related to this PR
77fbd52
to
d032dc7
Compare
ElectricStorage
andGenerator
havereplacement_year
inputs. It is assumed that these two technologies can be replaced within the analysis period.ElectricStorage
andGenerator
:--
replace_macrs_option_years
--
replace_macrs_bonus_fraction
--
replace_total_itc_fraction
effective_cost()
calculationTODO:
Note! I haven't looked into tax treatment assumptions built into replacement costs with battery degradation modeling.