feat: Multiple updates to the Plexos parser #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 62.18% 72.09% +9.90%
==========================================
Files 29 31 +2
Lines 3115 3472 +357
==========================================
+ Hits 1937 2503 +566
+ Misses 1178 969 -209 ☔ View full report in Codecov by Sentry. |
ktehranchi
force-pushed
the
kt/pwl_fix
branch
from
6ad57be
to
eb2b428
Compare
ktehranchi
commented
Oct 11, 2024
| self.device_match_string = self.config.defaults["device_name_inference_map"] or {} | ||
| self.generator_models = self.config.defaults["generator_models"] or {} | ||
| self.year = self.config.solve_year | ||
| assert isinstance(self.year, int) |
There was a problem hiding this comment.
@pesap Is there a reason you added this here? It causes crash since we look for study year at line 181. The if statement if not self.year can never be true since we are asserting it is an instance of int here.
pesap
changed the title
This was
linked to
issues
Oct 22, 2024
This was
linked to
issues
Oct 22, 2024
Closed
also skipping deactivated lines
List of changes: - Added new data file format for plexos data files - Added transformer parsing on plexos - Added correct fields for transformer on Sienna - Added same property logic for buses
factor is a time series
default. This assumes that all the data we pass is not normalize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to convert quadratic to PWL (quad2pwl) will now have outputs that enforce monotonically increasing PWL functions. cvxpy dependency added.
List of changes: