-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to EnergyPlus v24.2.0a #5242
Conversation
V24.2.0-IOFreeze: AirTerminalSingleDuctXXXPIUReheat's new fields, follow-up
Make pip install run only once instead of everytime CMake reconfigures
Built the arm64 linux (22.04 and 24.04), the windows i386, and the Centos one. https://github.com/NREL/EnergyPlus/releases/tag/v24.2.0a
Update to E+ v24.2.0a
Ok I think this is pretty much ready to drop, except CI is very broken and I don't have the rights to make changes. So it's hard to tell if the tests are green... I can vouch for Ubuntu (24.04) and macOS (arm64) building just fine. I have test failures on macOS arm64, but I often have numerical inconsistencies on that machine Tests I think should be fine on other machines:
Other tests that are suspicious.
@joseph-robertson can you report on what you find on windows? Does it build? How are tests? |
Hum the Run_RubyPythonPlugin thing is a codesigning issue, so mac only. I think I can fix it, but it's going to require rebuilding an E+ package... |
runs-on: ubuntu-20.04 | ||
# That container is too old to work with the actions that are on node20 now... | ||
#container: | ||
# image: nrel/cppcheck:2.3 | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Install cppcheck | ||
shell: bash | ||
run: | | ||
# I made a PPA on launchpad where I built cppcheck 2.3 for focal | ||
sudo add-apt-repository ppa:jmarrec/ppa | ||
sudo apt update | ||
sudo apt install -y cppcheck | ||
cppcheck --version | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unbrick the cppcheck workflow... since that one is on Github actions, I can do that. And apparently I had already made a launchpad PPA that built cppcheck 2.3 for focal a year ago (can't remember how I did that...)
CI Results for 37d6cca:
|
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.