Comment out debug print statements #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
reviewed
May 15, 2024
| @@ -34,7 +34,7 @@ namespace cli { | |||
| app->add_flag( | |||
| "-m,--measures_only", | |||
| [opt](std::int64_t val) { | |||
| fmt::print("val={}\n", val); | |||
| // fmt::print("val={}\n", val); | |||
| @@ -78,7 +78,7 @@ RubyEngine::~RubyEngine() { | |||
| // ruby_cleanup calls ruby_finalize | |||
| int ex = ruby_cleanup(0); | |||
| if (ex != 0) { | |||
| fmt::print("RubyEngine return code was {}\n", ex); | |||
| // fmt::print("RubyEngine return code was {}\n", ex); | |||
There was a problem hiding this comment.
I'm not sure I want this one gone...
There was a problem hiding this comment.
It doesn't seem like standard practice to print the exit code? After all, anyone can easily obtain the exit code themself.
There was a problem hiding this comment.
The message was to explain why it returned a non zero exit code.
When running something like
OpenStudio/src/cli/test/at_exit.rb
Lines 1 to 3 in 20d91f5
But sure, I suppose that's fine removing it
jmarrec
added
the
Pull Request - Ready for CI
jmarrec
approved these changes
May 21, 2024
jmarrec
force-pushed
the
comment_debug
branch
from
c7d1a59
to
eeb4e67
Compare
jmarrec
added
the
Ready for Merge
|
CI Results for eeb4e67:
|
|
Don't know what CI is tripping on, but this is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Comment out debug print statements