Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10663 - Fan runtime fraction < 1 when flow rate scaling using DesignSpecification:ZoneHVAC:Sizing #10673

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix #10663 - Fan runtime fraction < 1 when flow rate scaling using DesignSpecification:ZoneHVAC:Sizing #10673

wants to merge 6 commits into from

Commits on Aug 21, 2024

  1. Improve an existing unit test (I plan to use a variation of this)

    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9d0bef8 View commit details
    Browse the repository at this point in the history

  2. New unit test for #10663

    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    dddaa5a View commit details
    Browse the repository at this point in the history

  3. Take a reference directly

    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    52ffb00 View commit details
    Browse the repository at this point in the history

  4. Revamp the routine to take more references to shorten the code, scope… 

    … the variables, initialize them, don't check 4 times if CurZoneEqNum is > 0
    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5dbc7b1 View commit details
    Browse the repository at this point in the history

  5. Fix existing logic error related to Cooling Capacity sizing

    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f472e96 View commit details
    Browse the repository at this point in the history

  6. Set CoolingAirFlow flag in WindowAC so fan is sized by the WindowAC

    @jmarrec
    jmarrec committed Aug 21, 2024
    5 Configuration menu
    Copy the full SHA
    a5d32de View commit details
    Browse the repository at this point in the history