Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1ptt] PR: Fix error and warning scan bug #1320

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[1ptt] PR: Fix error and warning scan bug #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da7d25f
fix error bug
Oct 17, 2024
4bd5789
Update CHANGELOG.md
RobHanna-NOAA Oct 17, 2024
2232418
Merge branch 'dev' of https://github.com/NOAA-OWP/inundation-mapping …
Oct 21, 2024
bed6165
Merge branch 'dev' of https://github.com/NOAA-OWP/inundation-mapping …
RobHanna-NOAA Oct 25, 2024
3b9fb73
update changelog
RobHanna-NOAA Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
All notable changes to this project will be documented in this file.
We follow the [Semantic Versioning 2.0.0](http://semver.org/) format.


## v4.5.11.3 - 2024-10-25 - [PR#1320](https://github.com/NOAA-OWP/inundation-mapping/pull/1320)

The fix: During the post processing scan for the word "error" or "warning", it was only finding records which had either of those two words as stand alone words and not part of bigger phrases. ie); "error" was found, but not "fielderror". Added wildcards and it is now fixed.

Note: it is finding a good handful more errors and warnings that were being missed in earlier code versions.

### Changes
`fim_post_processing.sh`: fix as described.

<br/><br/>


## v4.5.11.2 - 2024-10-25 - [PR#1322](https://github.com/NOAA-OWP/inundation-mapping/pull/1322)

For security reasons, we needed to create a docker image that does not use the root user in anyway. The new `Dockerfile.prod` file is to be used when we want to use a non-root user. The original `Dockerfile` has been renamed to `Dockerfile.dev` and will continue to use it's root users which has no problems with interacting with external mounts.
Expand Down
4 changes: 2 additions & 2 deletions fim_post_processing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,11 @@ l_echo $startDiv"Scanning logs for errors and warnings. This can take quite a fe
echo "Results will be saved in root not inside the log folder."
Tstart
# grep -H -r -i -n "error" $outputDestDir/logs/ > $outputDestDir/all_errors_from_logs.log
find $outputDestDir -type f | grep -H -r -i -n "error" $outputDestDir/logs/ > \
find $outputDestDir -type f | grep -H -R -i -n ".*error.*" $outputDestDir/logs/ > \
$outputDestDir/all_errors_from_logs.log &
l_echo "error scan done, now on to warnings scan"

find $outputDestDir -type f | grep -H -r -i -n "warning" $outputDestDir/logs/ > \
find $outputDestDir -type f | grep -H -R -i -n ".*warning.*" $outputDestDir/logs/ > \
$outputDestDir/all_warnings_from_logs.log &
l_echo "warning scan done"
Tcount
Expand Down
Loading