-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13pt] PR: Modifying OSM bridge scripts #1298
Conversation
Merge remote-tracking branch 'origin/dev' into dev-osm-bridge
Using dissolve function to merge touching lines works well for addressing #1147, however, it also combines some bridges that should not be considered as a single bridge based on the current dev version and simplify technique. |
Awesome work, Zahra. Can you add to the description that you fixed several HUCs that had no bridges because of the duplicate columns? |
Thanks, Carson! I also added a line to convert polygon outputs into linestrings to be consistent with the previous version. |
New pre-clips loaded into Dev1, UCS2, FIM S3. I will do ESIP later this week. |
This PR addresses three issues regarding OSM bridges. It dissolves touching bridge lines so each bridge has a single linestring. It also removes abandoned bridge from the dataset and it adds bridge type field to bridge centroids. As part of this PR,
max_hand_ft
andmax_discharge_cfs
columns are added toosm_bridge_centroids.gkpg
.The pre-clip and osm bridges were updated following changes in this PR.
Changes
data/bridges/pull_osm_bridges.py
src/heal_bridges_osm.py
src/bash_variables.env
Deployment Plan (For developer use)
How does the changes affect the product?
Update: Oct 7th:
(S3, ESIP, Dev1, UCS2)
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)