[1pt] PR: Stop Whitebox from downloading during runtime #1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops Whitebox from downloading during runtime. Not only does this slow down the
fim_pipeline
runtime, but it leaves a vulnerability to changes in the file being downloaded from Whitebox and/or errors if the Whitebox server is down.Closes #1209.
Changes
Dockerfile
: setsWBT_PATH
environment variable which stops the Whitebox download (Whitebox is manually downloaded duringdocker build
).Pipfile
andPipfile.lock
: Upgrades Whitebox to v2.3.5.fim_pre_processing.sh
: Removes unnecessaryWBT_PATH
assignment.src/
agreedem.py
andunique_pixel_and_allocation.py
: Setswhitebox_dir
toWBT_PATH
.Testing
Ran container with
--network none
to disable network, then ranfim_pipeline
andsynthesize_test_cases
on HUC 03100204.Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)