-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: update SRC optimization w/ ras2fim v2 inputs #1247
Conversation
- ras2fim rating curves have error in the cms variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was tested on 3 HUC8 of 11010004, 12030109, and 12040101. The fim_pipline was successfully ran and synthesize_testcases.py also was ran successfully. The results of this test is availble on /efs-drives/fim-dev-efs/fim-home/heidi.safa/projects/dev-ras2fim-calb-update/outputs/pr_ras2fim/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the catalog approved.
Updated the gauge crosswalk and SRC adjustment routine to use the ras2fim v2 files. The v2 ras2fim file structure was changed to organize the data by huc8 - one gpkg and csv per huc8. Addresses #1091
Changes
fim_post_processing.sh
: added new input variables for running thesrc_adjust_ras2fim_rating.py
src/bash_variables.env
: renamed and reassigned the ras2fim input variables:ras2fim_input_dir
,ras_rating_curve_csv_filename
,ras_rating_curve_gpkg_filename
src/run_unit_wb.sh
: Added logic to check if huc in process has ras2fim input data to process. If yes - copy the ras2fim cross section point gpkg to the huc run directory.src/src_adjust_ras2fim_rating.py
: Updated code logic to use the huc-specific input files containing the ras2fim rating curve data (previous ras2fim input file contained all hucs in one csv)src/utils/shared_functions.py
: Added function to find huc subdirectories with the same name btw two parent foldersTesting
I ran fim_pipeline.sh for the 12 huc8s that have v2 ras2fim data.
Alpha Test results show a modest improvement for 4 BLE sites:
Notes
The new ras2fim v2 input files are already available in all the necessary systems (
/inputs/rating_curve/ras2fim_exports/v2_0/
)Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)