Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Update Manning numbers with Alaska feature ids #1232

Closed
wants to merge 2 commits into from

Conversation

AliForghani-NOAA
Copy link
Collaborator

@AliForghani-NOAA AliForghani-NOAA commented Jul 23, 2024

This PR incorporates Manning numbers for Alaska feature ids, needed for calibration. The new Manning dataset is available on dev1 here:
"/dev_fim_share/foss_fim/outputs/ali_alaska_calib/mannings_global_nwm3.csv"

The CSV file should be added into '${inputsDir}/rating_curve/variable_roughness/' directory.

Changes

  • src/bash_variables.env
    • it now refers to the new Manning file created from the new NWM3 dataset (available on dev1 at "/dev_fim_share/foss_fim/inputs/rating_curve/nwm_recur_flows/nwm3_17C_recurrence_flows_cfs.csv")

Testing

@RobHanna-NOAA Please test this against 'dev-update-aep" branch (PR 1198).

After cloning 'dev-update-aep' branch, made a successful FIM run on Alaska HUC 19020302. The run also successfully applied the calibration from a USGS gage within the HUC. Plot below shows a typical change in SRC for one of HydroIDs:

image

Alpha test results below confirm validity of the above calibration:
image

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@AliForghani-NOAA AliForghani-NOAA added the enhancement New feature or request label Jul 23, 2024
@AliForghani-NOAA AliForghani-NOAA self-assigned this Jul 23, 2024
@AliForghani-NOAA AliForghani-NOAA changed the title [1pt] PR: Update Manning numbers for Alaska feature ids [1pt] PR: Update Manning numbers with Alaska feature ids Jul 23, 2024
@AliForghani-NOAA AliForghani-NOAA marked this pull request as ready for review July 23, 2024 20:56
@AliForghani-NOAA AliForghani-NOAA changed the base branch from dev to dev-alaska-calibration-updated July 23, 2024 22:04
@AliForghani-NOAA AliForghani-NOAA changed the base branch from dev-alaska-calibration-updated to dev July 23, 2024 22:21
@AliForghani-NOAA
Copy link
Collaborator Author

Incorporated the required changes (a single line of adding new Manning numbers file) into PR 1198 .

@AliForghani-NOAA AliForghani-NOAA deleted the dev-alaska-calibration branch August 7, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FIM4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant