[1pt] PR: Update Manning numbers with Alaska feature ids #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates Manning numbers for Alaska feature ids, needed for calibration. The new Manning dataset is available on dev1 here:
"/dev_fim_share/foss_fim/outputs/ali_alaska_calib/mannings_global_nwm3.csv"
The CSV file should be added into '${inputsDir}/rating_curve/variable_roughness/' directory.
Changes
Testing
@RobHanna-NOAA Please test this against 'dev-update-aep" branch (PR 1198).
After cloning 'dev-update-aep' branch, made a successful FIM run on Alaska HUC 19020302. The run also successfully applied the calibration from a USGS gage within the HUC. Plot below shows a typical change in SRC for one of HydroIDs:
Alpha test results below confirm validity of the above calibration:
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally/foss_fim/
, run:pytest unit_tests/
)4.x.x.x
Merge Checklist (For Technical Lead use only)