[1pt] PR: log duration times per module for post processing #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having problems with post processing overall duration taking a long time. This new system captures duration times for each module/section inside fim_post_processing.sh and records it to a file on the output directory. It records it as it progress and will also help us learn if fim_post_processing.sh stopped along the way.
Note: When used in code, we call
Set_log_file_path
shell variable with a file name and path (no validation done at this time). The each time a person wants to print to screen and console, use thel_echo
command instead of the nativeecho
command. If the log file has not been set, the output will continue to go to screen, just not the log file.Changes
fim_pipeline.sh
: A couple of minor text output changes.fim_post_processing.sh
: As described above.src\bash_functions.env
: New functions and adjustments to support the new log system.Testing
Start with a fim_pipeline.sh with any huc is fine. You should see the new
post_proc.log
file. If you re-run it and overwrite the output, it should create a whole new replacement post_proc.log file. It should also clear if if you re-run, just fim_post_processing.shDeployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally/foss_fim/
, run:pytest unit_tests/
)4.x.x.x
Merge Checklist (For Technical Lead use only)