Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Upgrade JDK to v21.0.3 #1211

Closed
wants to merge 2 commits into from
Closed

[1pt] PR: Upgrade JDK to v21.0.3 #1211

wants to merge 2 commits into from

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Jul 10, 2024

Upgrades JDK in docker image to v21.0.3. Whether or not this resolves #1208 depends on if this passes ITSG's security vulnerability scan. A docker system prune (e.g., docker system prune -a --volumes) should be done on all environments prior to the scan.

Changes

  • Dockerfile: Changes JDK version from 19 to 21.

Testing

root@fea67221b25b:/# java --version
openjdk 21.0.3 2024-04-16
OpenJDK Runtime Environment (build 21.0.3+9-Ubuntu-1ubuntu122.04.1)
OpenJDK 64-Bit Server VM (build 21.0.3+9-Ubuntu-1ubuntu122.04.1, mixed mode, sharing)

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck added enhancement New feature or request High Priority dependencies Pull requests that update a dependency file FIM4 labels Jul 10, 2024
@mluck mluck requested a review from RobHanna-NOAA July 10, 2024 14:31
@mluck
Copy link
Contributor Author

mluck commented Jul 10, 2024

I tested building the latest version (v3.9.1) of GDAL (ubuntu-full-3.9.1) from the GDAL Dockerfile after updating ARG JAVA_VERSION=21. Although it built successfully, that didn't resolve the issue (see output below), so hopefully this PR will pass the scan.

root@119fc7a177d2:/# java --version
openjdk 17.0.11 2024-04-16
OpenJDK Runtime Environment (build 17.0.11+9-Ubuntu-1)
OpenJDK 64-Bit Server VM (build 17.0.11+9-Ubuntu-1, mixed mode, sharing)

@RobHanna-NOAA
Copy link
Contributor

This PR is now closed as it is being redone in PR 1217 Docker, python packages and jdk updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request FIM4 High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8pt] Bump OpenJDK from 17.0.8 to 17.0.10
3 participants