Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Upgrade whitebox to v2.3.4 #1183

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

mluck
Copy link
Contributor

@mluck mluck commented May 29, 2024

Upgrades whitebox from v2.3.1 to 2.3.4. Whitebox was upgraded by pip install -U whitebox and then pipenv lock to update the Pipfile. Fixes #1181.

This PR also includes updates manually redone in this PR, both dependabot PRs. 1174 requests pkg and 1187 tornado pkg

Changes

  • Dockerfile: Removed whitebox hack
  • Pipfile and Pipfile.lock: Upgraded whitebox to v2.3.4, requests and tornado packages.

Testing

The Docker image build and fim_pipeline.sh ran successfully.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck added bug Something isn't working dependencies Pull requests that update a dependency file labels May 29, 2024
@mluck mluck requested a review from RobHanna-NOAA May 29, 2024 17:45
@mluck mluck self-assigned this May 29, 2024
RobHanna-NOAA
RobHanna-NOAA previously approved these changes Jun 13, 2024
RobHanna-NOAA
RobHanna-NOAA previously approved these changes Jun 14, 2024
Copy link
Contributor

@RobHanna-NOAA RobHanna-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to add "requests" and "tornado" packages and fully retested with new test container.

@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit 5b9a8ce into dev Jun 14, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-whitebox-2.3.4 branch June 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[13pt] Docker build error with Whitebox
3 participants