Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Healed hand removing hydro-conditioning artifacts and testing #1156

Merged
merged 8 commits into from
May 17, 2024

Conversation

hhs732
Copy link
Contributor

@hhs732 hhs732 commented May 10, 2024

This PR focuses on removing hydro-conditioning artifacts by subtracting the thalweg DEM from HAND REM and adding back the original DEM. Also, a new tool was created to test this feature over multiple HUCs

Additions

  • tools/analyze_for_missing_FIM_cells.py: A new script analyze_for_missing_FIM_cells.py was added to test and analyze healed HAND for hydro-conditioning artifacts FIM.

Changes

  • src/delineate_hydros_and_produce_HAND.sh: Removing hydro-conditioning artifacts from HAND REM.
  • config/params_template.env: Creating an option to include/exclude healed HAND from FIM pipeline.

Testing

This PR has been tested over 2 HUC8s including 12090301 and 01080107.

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@hhs732 hhs732 self-assigned this May 10, 2024
@hhs732 hhs732 added enhancement New feature or request FIM4 labels May 10, 2024
@hhs732 hhs732 marked this pull request as ready for review May 13, 2024 18:48
@hhs732
Copy link
Contributor Author

hhs732 commented May 14, 2024

image

@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit eaeb4c8 into dev May 17, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-healed-hand-removing-hcas branch May 17, 2024 20:10
@hhs732
Copy link
Contributor Author

hhs732 commented Jun 3, 2024

hcr_map (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FIM4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[21pt] Develop "healed" HAND workflow that removes hydroconditioning artifacts from depth grids
2 participants