Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Fix erroneous branch inundation in levee-protected areas #1059

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Dec 29, 2023

Fixes erroneous branch inundation in levee-protected areas.

Levees disrupt the natural hydrology and can create large catchments that contain low-lying areas in levee-protected areas that are subject to being inundated in the REM (HAND) grid. However, these low-lying areas are hydrologically disconnected from the stream associated with the catchment and can be erroneously inundated. Branch inundation in levee-protected areas is now confined to the catchment for the levelpath. Fixes #1021. Note: this does not fix the similar issue in branch 0 in #978.

Changes

  • src/
    • delineate_hydros_and_produce_HAND.sh: Adds input argument for catchments.
    • mask_dem.py: Adds DEM masking for areas of levee-protected areas that are not in the levelpath catchment.

Testing

Verified that the problem area in HUC 01080205 (#1021) has been fixed. CSI and MCC for 12040101 and 12090301 remain unchanged.

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck linked an issue Dec 29, 2023 that may be closed by this pull request
@mluck mluck added bug Something isn't working FIM4 labels Dec 29, 2023
RyanSpies-NOAA
RyanSpies-NOAA previously approved these changes Jan 5, 2024
Copy link
Collaborator

@RyanSpies-NOAA RyanSpies-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code changes and successfully ran fim_pipeline.sh for HUC 11010007 -->
image

@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit 4b2762d into dev Jan 5, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-levee-catchments branch January 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIM4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8pt] Leveed area being inundated by branch
3 participants