Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2pt] PR: Hotfix for a switched global manning file #1052

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

CarsonPruitt-NOAA
Copy link
Collaborator

@CarsonPruitt-NOAA CarsonPruitt-NOAA commented Dec 12, 2023

The alpha test for v4.4.8.1 came back with a large degradation in skill and we noticed that the global manning's roughness file was changed in v4.4.7.1 - likely in error.

Changes

  • src/bash_variables.env: changed the global roughness file to vmann_input_file=${inputsDir}/rating_curve/variable_roughness/mannings_global_06_12.csv

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@CarsonPruitt-NOAA CarsonPruitt-NOAA self-assigned this Dec 12, 2023
@CarsonPruitt-NOAA CarsonPruitt-NOAA added the bug Something isn't working label Dec 12, 2023
Copy link
Contributor

@robgpita robgpita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes a quick fim_pipeline.sh test on one HUC. Hopefully this resolves the decrease in skill of the most recent alpha test.

@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit 5cca27c into dev Dec 13, 2023
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-global-roughness-file branch December 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants