Skip to content

Commit

Permalink
Merge branch 'dev-docker-root' of https://github.com/NOAA-OWP/inundat…
Browse files Browse the repository at this point in the history
…ion-mapping into dev-docker-root
  • Loading branch information
RobHanna-NOAA committed Oct 24, 2024
2 parents c98b7c6 + 5b51feb commit 5c0174d
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,24 @@ We follow the [Semantic Versioning 2.0.0](http://semver.org/) format.

## v4.5.11.2 - 2024-10-22 - [PR#1322](https://github.com/NOAA-OWP/inundation-mapping/pull/1322)

For security reasons, we needed to create a docker image that does not use the root user in anyway. This can only be used on OWP servers at this time.
For security reasons, we needed to create a docker image that does not use the root user in anyway. The new `Dockerfile.prod` file is to be used when we want to use a non-root user. The original `Dockerfile` has been renamed to `Dockerfile.dev` and will continue to use it's root users which has no problems with interacting with external mounts.

Note: Re: using pip or pipenv installs.
In the Dockerfile.prod, you can not do installs or update using either pipenv or pip. Those types of tests and adjustments need to be done in the `Dockerfile.dev`. `Dockerfile.dev` will also allow change to the `Pipfile` and `Pipfile.lock` . Both docker files share the Pipfiles so it should be just fine.

### File Renames
- Was: `Dockerfile`, now `Dockerfile.dev`

### Additions

- owp.Dockerfile: as described
- Dockerfile.prod: as described

### Changes
- `README.md`: change notes from phrase `Dockerfile` to `Dockerfile.dev`. Also added some notes about the new convention of outputs no longer starting with `fim_` but now `hand_`
- `fim_pipeline.sh`: Change for the new `Dockerfile.prod` for permissions.
- `fim_post_processing.sh`: Change for the new `Dockerfile.prod` for permissions.
- `fim_pre_processing.sh`: Change for the new `Dockerfile.prod` for permissions.
- `fim_process_unit_wb.sh`: Change for the new `Dockerfile.prod` for permissions.

<br/><br/>

Expand Down

0 comments on commit 5c0174d

Please sign in to comment.