Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-categorical tutorial #151

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Add multi-categorical tutorial #151

merged 3 commits into from
Aug 16, 2023

Conversation

GregoryPetrochenkov-NOAA
Copy link
Collaborator

This issue addresses #150.

Additions

  • SphinxMulticatTutorial.ipynb/Multi-Class Categorical Statistics.ipynb
  • tutorials.rst
  • benchmark_map_multi_categorical.tif
  • candidate_map_multi_categorical.tif
  • candidate_raw_elevation_multi_categorical.tif

Changes

  • PyPi/Sphinx/README.MD: Automatic formatting from black
  • compile_readme_and_arrange_docs.py: Add copy of multi-cat tutorial notebook for sphinx
  • index.rst: Add tutorials folder
  • Tutorial.ipynb/SphinxTutorial.ipynb: Change title to Two-Class Categorical Comparisons

Copy link
Member

@fernando-aristizabal fernando-aristizabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregoryPetrochenkov-NOAA It looks really good. My only recommendation is to change functions to the following styles:

func(
    arg0 = val0, arg1 = val1, arg2 = val2, arg3 = val3
)

or

func(
    arg0 = val0,
    arg1 = val1,
    arg2 = val2,
    arg3 = val3
)

args are only indented once which creates more space and more aligned with how black formats our code.

@fernando-aristizabal fernando-aristizabal merged commit f90f636 into main Aug 16, 2023
4 checks passed
@fernando-aristizabal fernando-aristizabal deleted the multicat_example branch August 16, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants