Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash #c127601 (Jul 19) #169

Closed

Conversation

kayeekayee
Copy link

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

JiliDong-NOAA and others added 30 commits January 31, 2024 10:50
…es (ufs-community#2098)

fix NSSL MP init issue when initialized from other microphysics schemes
…osphere-ocean coupling (ufs-community#2104)

Enable the capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling. A namelist option is added to control whether or not to use this feature (default is off). Fixes ufs-community#1975

Co-authored by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA
Developed and enabled using CMEPS with inline CDEPS capability for UFS regional coupling.
Two HAFS regional moving nest atm_ocn_wav coupling regression tests were added to test this capability.
Note: This is a collaborative effort among the ESMF team, EMC/EIB, and EMC hurricane project team.
- Add three new regression tests for version 2 of the surface coldstart file. (Closes ufs-community#1977)
UPP will be brought to the commit to fix the missing reflectivity bug for NSSL MP cases.
…lock_atmos_copy routines in fv3atm ufs-community#2124 (ufs-community#2115)

- Gaea C5 modulefile & DISKNM update: closes issues Gaea F2 to F5 file system migration ufs-community#2101
- Bring in the global-workflow detect_machine.sh to keep consistent between projects. (Closes Bring in detect_machine.sh 
   from global workflow for consistency across the community. ufs-community#2096 )
- Fix out of bound errors in block_atmos_copy routines in fv3atm
…file (ufs-community#2062)

Add option to write 3d soilt, soilw and soill variables to a history file
…f support, simplify RT logs. (ufs-community#2061)

* UFSWM
  * Re-work test verification in rt.sh for developers to use in PR process. (Closes ufs-community#2058)
  * fail_<test_number> file name upgraded to use compile/test name instead of number.
  * Regression test logs do not clearly indicate when a test fails to run. (Closes ufs-community#1821)
  * New test_changes.list file:
    * Verification of what tests change for each PR.
    * Used with './rt.sh -c -b test_changes.list` to help create new baselines for each PR.
…run compile jobs of regression test suite only & -mcmodel=medium gnu.cmake option (also includes ufs-community#2142) (ufs-community#2066)

* UFSWM - Add option to `rt.sh` to run compile-only tests
  * FV3 - Update submodule pointer (NOAA-EMC/fv3atm#747)
    * ccpp-physics - Update submodule pointer (ufs-community/ccpp-physics#150)
    * ccpp-framework - Update submodule pointer (NCAR/ccpp-framework#519)
* Update WM license and documentation logo
* Update GNU.cmake: -mcmodel=medium
Changes to physics code such that the ice model is used to determine the ice temperature over both sea ice and lake ice
* MOM6 - 
update MOM6 to its main repo. 20240228 updating (which is the original GFDL 20231113 candidate PR)
…ll on macOS arm64 (also contains ufs-community#2017) (ufs-community#2164)

* UFSWM - "Add conflict for MOVING_NEST option with GNU Fortran, use mcmodel=small on macOS arm64"
   * FV3 - "Bug fix for unallocated array sfcprop%wetness in      GFS_diagnostics.F90"
     * ccpp-physics - 
     * ccpp-framework - "Bug fix required to use chunked arrays and retain backward compatibility with blocked data 
        structures in ccpp_prebuild.py"
   * Creation of UFS-WM jenkinsfile for pipeline integration
   * Jet Rocky8 updates
     * spack-stack module path
     * eflow location and version
…g templates for global apps and append _esmf for templates using ESMF-managed threading (was ufs-community#2179) (ufs-community#2172)

* CICE and CMEPS - Remove compiler warnings.
* UFSWM - Allow flexibility to use traditional or ESMF-managed threading for global apps.
…ommunity#2180)

* UFSWM - Update the CS convection scheme
  * FV3 - Update the CS convection scheme
    * ccpp-physics - Update the CS convection scheme
…ure/capgen into main/20240308) Combined PR ufs-community#2190 (ufs-community#2181)

* FV3 - Update submodule pointers for ccpp-framework and ccpp-physics. Change units flashes 5 min-1 to flashes min-1 and update long name to make clear this is per 5 minutes.
    * ccpp-physics - In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.meta: change units flashes 5 min-1 to flashes min-1 and update long name to make clear this is per 5 minutes.
    * ccpp-framework - Update main from feature/capgen as of 2024-03-08 (includes optional argument updates in feature/capgen). Only commit on top of the merge is NCAR/ccpp-framework@6cdd38a which is required to parse the metadata in the Unified Forecast System / ccpp-physics (underscores in units, e.g. degree_north).
…allow-argument-mismatch' flag (ufs-community#1147)

* UFSWM - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag.
  * FV3 - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag.
    * ccpp-physics - Resolve various subroutine argument mismatches.
    * ccpp-framework - Add support to use mpi_f08 MPI module .
  * stochastic_physics - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag.
- update module paths in Hera intel/gnu lua files for Rocky8 OS spack-stack libraries.
…ity#2197), add xr_cnvcld flag to FV3 (ufs-community#2185) (ufs-community#2202)

* UFSWM - atparse.bash: correctly handle input that doesn't end with an end-of-line character. Fix some bugs in Rocoto support and clean up rt.sh.
  * FV3 - namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite
    * ccpp - physics-level changes to implement new namelist variable
  * MOM6 - update MOM6 code to eliminate all compiler warnings
…#2193)

* UFSWM - Update module_write_netcdf to avoid hangs in RRFS runs
  * FV3 - Update module_write_netcdf to avoid hangs in RRFS runs
…ommunity#2175)

  * CMEPS - allow additional dimension in cpl_scalars for CSG and regional ATM domains for use in mediator history files 
  * CMEPS - fix mapping mask for lnd->atm
  * FV3 - add export of cpl_scalars
  * NOAHMP - add export of cpl_scalars
…fs-community#2223)

cubed_sphere hash update: f060e85 for a bug- fix in the HAILCAST diagnostic code (units issue)
Update to CICE-Consortium/CICE aca8357. Adds implementation of namelist PIO options for CICE
…m wrong for nests (ufs-community#2201)

* UFSWM - None.
  * FV3 - Write component will use kchunk3d. Model init sends the right tile number to CCPP.
    * atmos_cubed_sphere - Initialize the hailwat variable. Pass global_tile index to model.
*doc/UserGuide
   *requirements.txt - updates inda version from 3.6 to 3.7
* UFSWM 
  * doc/Userguide
    * source
      * conf.py
      * Configurations.rst
      * FAQ.rst
      * InputsOutputs.rst
      * Introduction.rst
…Adds -v Verbose option. (ufs-community#2218)  Remove nowarn Intel compiler flag (ufs-community#2225)

* UFSWM
- Add bash linting to CI:
  - uses superlinter to check for consistent bash code writing
- Cleans up .sh scripts to comply with superlinter
- Cleans up .sh scripts to be more consistent, easier to read.
- Add's -v verbose option if debugging outputs needed, otherwise simplifies rt.sh run echo's.
- Addresses smaller bugs
  - quota/timeout search logic adjusted.
  - check for dirs existing (DISKNM, STMP, PTMP) before starting.
  - adjustments/cleanup to ecflow/rocoto sections
  - rt.sh will attempt to start ecflow, and only stop ecflow if it started from rt.sh.
  - fix for issue where run_dir will not delete properly.
* FV3: Address compiler warnings
  * atmos_cubed_sphere: Address compiler warnings.
* UFSWM - Update inline post
  * FV3 - Update upp submodule for inline post
* UFSWM - global_control.nml_IN has been added as the new regression test namelist template for all global regression tests. The namelist now uses pointers (i.e. @[abc]) for variables and default values have been added to the default_vars.sh script. A new section in default_vars.sh has been added (export_tiled) to account for tiled RTs that pulls the correct parameter files using the ATMRES variable.
Regression tests have been modified to account for these changes. Tests that were not compatible with the GFSv17_p8 core have been disabled for now. They will be turned on as they are updated from GFSv16 to GFSv17.
NickSzapiro-NOAA and others added 29 commits June 11, 2024 11:21
…nts (ATM_DS2S and ATM_DS2S-PCICE) and regression tests (atm_ds2s_docn_dice and atm_ds2s_docn_pcice) (ufs-community#2186)

* UFSWM - Add ATM_DS2S and ATM_DS2S-PCICE applications by adding CDEPS dice and enabling prescribed ice CICE. Add corresponding atm_ds2s_docn_dice and atm_ds2s_docn_dice-pcice regression tests. New gnv1_nested regression test with Water in the West domain at C96 resolution using templates compatible with global-workflow
  * CDEPS - Add dice cplhist datamode
  * CICE - Enable ice prescribed CICE mode
*UFSWM - update WAM RT compatible with v17
*UFSWM - fix derecho modulefile path for Spack Stackv1.6
…s_cubed_sphere to fix a typo when printing out the nest grid corner locations ufs-community#2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide ufs-community#2329 + Orion changes for switch to new OS - Rocky-9 ufs-community#2336 (ufs-community#2324)

  * CICE - Adds restart write capability at the end of a run for CICE
  * FV3 - 
    * atmos_cubed_sphere - Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations
    * doc/UsersGuide/requirements.txt: Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
    * Orion Spack stack modulefile update: Rocky-9
    * update detect_machine.sh: hercules
… similar to hydrostatic method (ufs-community#2327)

    * atmos_cubed_sphere - 
               A new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode, has been added in 
               dycore. When set to true, the omega calculation will match that of hydrostatic runs, using the 
               formula omega = dp/dt. The default value is false, where the calculation remains
               omega = w * dp/dz as before.
* HR4 GWD update for FV3

* point to PR#549 of ccpp-framework

* Update default_vars.sh: GWD parameters

* Update global_control.nml.IN

* update cpld case GWD parameters: gfsv17

* Update Jenkinsfile.combined fix multi-label removal

* Update Jenkinsfile for ORT Pipeline

* update input oro files for control_run.IN: gsfv17

---------

Co-authored-by: Grant Firl <[email protected]>
Co-authored-by: Jong Kim <[email protected]>
Co-authored-by: Dustin Swales <[email protected]>
Co-authored-by: zach1221 <[email protected]>
* UFSWM - 
  * FV3 - 
    * atmos_cubed_sphere - bug fix to address debug mode crashes caused by floating-point exception in subroutine a2b_ord2 in model/a2b_edge.F90
…nd PR#2265) (ufs-community#2335)

* UFSWM - restore error checking to regression test system and add a self-test suite
	        - Detect_machine.sh identifies Frontera
---------
Co-authored-by: Sam Trahan <[email protected]>
Co-authored-by: Benjamin Cash <[email protected]>
… in the GFS physics suite (ufs-community#2340)

* ccpp-physics - update convection and PBL schemes to improve cloud/convection interaction

* Output updraft value of convective cloud condensate in FV3 and CCPP

* update xkinv1 to 0.15

* add check if progsigma is true
@kayeekayee kayeekayee closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.