Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corrections to the variable names for GEFS #2969

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add corrections to the variable names for GEFS #2969

merged 1 commit into from
Oct 7, 2024

Conversation

EricSinsky-NOAA
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA commented Oct 1, 2024 •
edited
Loading

Description

Corrections were made to the GEFS variable names in the parm files so that they can be successfully extracted from the atmos master files in the atmos_prod task.

Resolves #2967

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

This PR was tested on WCOSS2 using a GEFS CI run.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@EricSinsky-NOAA
Add corrections to the GEFS variable names
6f8f9cb 
Corrections were made to the GEFS variable names in the parm files so that they can be extracted from the atmos master files.
@EricSinsky-NOAA EricSinsky-NOAA marked this pull request as ready for review October 1, 2024 19:17
@EricSinsky-NOAA
Copy link
Contributor Author

The WCOSS2 test was successful. The variables originally missing from pgrb are now being produced in atmos_prod.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Oct 2, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Oct 2, 2024
@emcbot
Copy link

emcbot commented Oct 2, 2024

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/stmp/CI/HERCULES/2969/RUNTESTS/COMROOT/C96C48_hybatmDA_6f8f9cba/logs/2021122106/enkfgdasfcst_mem001.log
/work2/noaa/stmp/CI/HERCULES/2969/RUNTESTS/COMROOT/C96C48_hybatmDA_6f8f9cba/logs/2021122106/enkfgdasfcst_mem002.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Oct 2, 2024
@emcbot
Copy link

emcbot commented Oct 2, 2024

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 in
/work2/noaa/stmp/CI/HERCULES/2969/RUNTESTS/EXPDIR/C96C48_hybatmDA_6f8f9cba

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Oct 2, 2024
@emcbot
Copy link

emcbot commented Oct 2, 2024

CI Failed on Hercules in Build# 1
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2969


Experiment C48_ATM_6f8f9cba Completed 1 Cycles: *SUCCESS* at Wed Oct  2 02:37:40 CDT 2024
Experiment C96C48_hybatmDA_6f8f9cba Terminated with 0
FAIL
FAIL tasks failed and 2 dead at Wed Oct  2 03:32:24 CDT 2024
Experiment C96C48_hybatmDA_6f8f9cba Terminated: *FAIL*
Error logs:
/work2/noaa/stmp/CI/HERCULES/2969/RUNTESTS/COMROOT/C96C48_hybatmDA_6f8f9cba/logs/2021122106/enkfgdasfcst_mem001.log
/work2/noaa/stmp/CI/HERCULES/2969/RUNTESTS/COMROOT/C96C48_hybatmDA_6f8f9cba/logs/2021122106/enkfgdasfcst_mem002.log
Experiment C48_S2SWA_gefs_6f8f9cba Completed 1 Cycles: *SUCCESS* at Wed Oct  2 04:21:26 CDT 2024
Experiment C48_S2SW_6f8f9cba Completed 1 Cycles: *SUCCESS* at Wed Oct  2 04:26:47 CDT 2024
Experiment C96_atm3DVar_6f8f9cba Completed 3 Cycles: *SUCCESS* at Wed Oct  2 04:32:46 CDT 2024

@EricSinsky-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA I don't believe the reasons for the C96C48_hybatmDA CI test failure are related to the changes made in this PR.

@WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA I don't believe the reasons for the C96C48_hybatmDA CI test failure are related to the changes made in this PR.

Agreed. Not sure why the model would suddenly be blowing up now.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 3, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 3, 2024
@emcbot
Copy link

emcbot commented Oct 5, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/2969


Experiment C48mx500_3DVarAOWCDA_6f8f9cba Completed 2 Cycles: *SUCCESS* at Sat Oct  5 03:51:43 UTC 2024
Experiment C48_ATM_6f8f9cba Completed 1 Cycles: *SUCCESS* at Sat Oct  5 05:15:55 UTC 2024
Experiment C48_S2SW_6f8f9cba Completed 1 Cycles: *SUCCESS* at Sat Oct  5 08:33:53 UTC 2024
Experiment C96_atm3DVar_6f8f9cba Completed 3 Cycles: *SUCCESS* at Sat Oct  5 08:37:31 UTC 2024
Experiment C48_S2SWA_gefs_6f8f9cba Completed 1 Cycles: *SUCCESS* at Sat Oct  5 08:45:06 UTC 2024
Experiment C96C48_hybatmDA_6f8f9cba Completed 3 Cycles: *SUCCESS* at Sat Oct  5 09:47:12 UTC 2024
Experiment C96C48_hybatmaerosnowDA_6f8f9cba Completed 3 Cycles: *SUCCESS* at Sat Oct  5 10:11:54 UTC 2024
Experiment C96C48_ufs_hybatmDA_6f8f9cba Completed 3 Cycles: *SUCCESS* at Sat Oct  5 10:48:28 UTC 2024

@WalterKolczynski-NOAA
Copy link
Contributor

Hercules failure is unrelated to this PR. It passes on Hera, so I am going to merge.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 330e74b into NOAA-EMC:develop Oct 7, 2024
10 of 11 checks passed
@EricSinsky-NOAA EricSinsky-NOAA deleted the bugfix/issue2967 branch October 7, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GEFS variables available in the forecast output are missing in the products
3 participants
@EricSinsky-NOAA @emcbot @WalterKolczynski-NOAA