Update global atmos vminmon job to use COMIN/COMOUT #2935
Conversation
mingshichen-noaa
requested review from
aerorahul,
WalterKolczynski-NOAA and
KateFriedman-NOAA
jobs/JGLOBAL_ATMOS_VMINMON
Outdated
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL |
There was a problem hiding this comment.
Does the same thing, but a bit easier to read and conforms with other jobs.
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL | |
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL | |
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | |
| COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL \ | |
| COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL |
There was a problem hiding this comment.
@WalterKolczynski-NOAA
Yes, I will change them.
jobs/JGLOBAL_ATMOS_VMINMON
Outdated
| YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx COM_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL | ||
| YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx COMOUT_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL |
There was a problem hiding this comment.
I checked the scripts. This is only used as an input.
There was a problem hiding this comment.
| YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx COMOUT_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL | |
| YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx COMIN_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL |
| if [[ ! -d ${M_TANKverf} ]]; then mkdir -p -m 775 "${M_TANKverf}" ; fi | ||
| if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p -m 775 "${M_TANKverfM1}" ; fi | ||
| if [[ ! -d ${M_TANKverf} ]]; then mkdir -p "${M_TANKverf}" ; fi | ||
| if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi |
There was a problem hiding this comment.
Since this is only an input, we shouldn't be creating it.
| if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi |
There was a problem hiding this comment.
@WalterKolczynski-NOAA
From scripts ( exglobal_atmos_vminmon.sh), these three directory variables should be input directories. Hence line 28 and 29 should be removed. Am I right?
There was a problem hiding this comment.
Only $M_TANKverfM1 is an input. $M_TANKverif is an output (the perl scripts write to it).
There was a problem hiding this comment.
@WalterKolczynski-NOAA
After reading 3 perl files in ush (minmon_xtrct_costs.pl minmon_xtrct_gnorms.pl minmon_xtrct_reduct.pl), gsistat should be only an input file defined in jobs/JGLOBAL_ATMOS_VMINMON. This implies the following modifications:
20 YMD=${PDY} HH=${cyc} declare_from_tmpl -rx
21 COMIN_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL
22 COMOUT_ATMOS_MINMON:COM_ATMOS_MINMON_TMPL
23
24 YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx
25 COMOUT_ATMOS_MINMON_PREV:COM_ATMOS_MINMON_TMPL
26
27 export gsistat="${COMIN_ATMOS_ANALYSIS}/${RUN}.t${cyc}z.gsistat"
28 export M_TANKverf=${M_TANKverf:-${COMOUT_ATMOS_MINMON}}
29 export M_TANKverfM1=${M_TANKverfM1:-${COMOUT_ATMOS_MINMON_PREV}}
30
31 if [[ ! -d ${M_TANKverf} ]]; then mkdir -p "${M_TANKverf}" ; fi
32 if [[ ! -d ${M_TANKverfM1} ]]; then mkdir -p "${M_TANKverfM1}" ; fi
33
There was a problem hiding this comment.
What modifications are you proposing? That looks like what is there now.
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global minimization monitor job.
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist