Merge branch 'NOAA-EMC:develop' into feature/gwdev_issue_2329

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,76 @@
+name: Bug report
+description: Report something that is incorrect or broken
+labels: ["bug", "triage"]
+
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Your bug may already be reported!
+ Please search on the [Issue tracker](https://github.com/NOAA-EMC/gfs-utils/issues) before creating one.
+
+ - type: textarea
+ id: current_behavior
+ attributes:
+ label: What is wrong?
+ description: Give a brief description of what is incorrect or broken.
+ placeholder: |
+ Short log snippets that illustrate the problem can be included here.
+
+ For any longer logs, please create a GitHub gist (https://gist.github.com/) and link it here.
+ validations:
+ required: true
+
+ - type: textarea
+ id: expected_behavior
+ attributes:
+ label: What should have happened?
+ placeholder: Describe what you expected to happen.
+ validations:
+ required: true
+
+ - type: dropdown
+ id: hpc
+ attributes:
+ label: What machines are impacted?
+ description: You may select multiple machines.
+ multiple: true
+ options:
+ - All or N/A
+ - WCOSS2
+ - Hera
+ - Orion
+ - Hercules
+ - Jet
+ - Cloud
+ validations:
+ required: true
+
+ - type: textarea
+ id: reproduction_steps
+ attributes:
+ label: Steps to reproduce
+ description: Please give explicit instructions to reproduce the error
+ placeholder: |
+ 1.
+ 2.
+ 3.
+ validations:
+ required: true
+
+ - type: textarea
+ id: description
+ attributes:
+ label: Additional information
+ description: Provide context or any additional information about the bug.
+ validations:
+ required: true
+
+ - type: textarea
+ id: propsed_implementation
+ attributes:
+ label: Do you have a proposed solution?
+ description: If you already have an idea on how to fix this, please provide it here.
+ placeholder: Optional
+ validations:
+ required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: false

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -0,0 +1,55 @@
+name: Feature request
+description: Request new capability
+labels: ["feature", "triage"]
+
+body:
+ - type: markdown
+ attributes:
+ value: |
+ If your issue falls into one of the follow categories, please go back and use the appropriate template:
+ - Something is wrong or broken
+ - It is a request from NCO
+ - It is initiating a production update
+ - Files need to be updated or added to fix
+
+
+ Please search on the [Issue tracker](https://github.com/NOAA-EMC/gfs-utils/issues) to make sure the feature has not already been requested to avoid duplicates.
+ 
+ - type: textarea
+ id: description
+ attributes:
+ label: What new functionality do you need?
+ placeholder: Provide a consise description of the problem to be addressed by this feature request. Please be clear what parts of the problem are considered to be in-scope and out-of-scope
+ validations:
+ required: true
+
+ - type: textarea
+ id: requirements
+ attributes:
+ label: What are the requirements for the new functionality?
+ validations:
+ required: true
+
+ - type: textarea
+ id: criteria
+ attributes:
+ label: Acceptance Criteria
+ placeholder: What does it mean for this issue to be complete?
+ validations:
+ required: true
+
+ - type: textarea
+ id: suggested_solution
+ attributes:
+ label: Suggest a solution (optional)
+ placeholder: |
+ Propose how this issue can be resolved.
+
+ Things to address include:
+ * Details of the technical implementation
+ * Tradeoffs made in design decisions
+ * Caveats and considerations for the future
+
+ If there are multiple solutions, please present each one separately. Save comparisons for the very end.)"
+ validations:
+ required: false

.github/pull_request_template.md

@@ -0,0 +1,52 @@
+<!-- PLEASE READ -->
+<!-- Any PRs not following this template will be closed -->
+<!--
+ Please use a short (<60 char), descriptive title above. It should complete the sentence "If merged, this PR will _____". Capitalize the first word and do not end with a period.
+
+ PRs should meet these guidelines:
+ - Each PR should address ONE topic and have an associated issue.
+ - No hard-coded paths or personal directories.
+ - No temporary or backup files should be committed (including logs).
+ - Any code that you disabled by being commented out should be removed or reenabled.
+
+ Please delete all these comments before submitting the PR.
+-->
+# Description
+<!-- This description will become the commit message for the PR-->
+<!-- Please use this format for your description:
+
+ Describe your changes. Focus on the *what* and *why*. The *how* will be evident from the changes. In particular, be sure to note any interface changes, such as command line syntax, that will need to be communicated to users.
+
+ At the end of your description, please be sure to add the issue this PR solves using the word "Resolves". If there are any issues that are related but not yet resolved (including in other repos), you may use "Refs".
+
+ Resolves #1234
+ Refs #4321
+ Refs NOAA-EMC/repo#5678
+-->
+
+# Type of change
+<!-- Delete all except one -->
+- Bug fix (fixes something broken)
+- New feature (adds functionality)
+- Maintenance (code refactor, clean-up, new CI test, etc.)
+
+# Change characteristics
+- Is this a breaking change (a change in existing functionality)? YES/NO
+- Does this change require a documentation update? YES/NO
+
+# How has this been tested?
+<!-- Please list any test you conducted, including the machine.
+
+Example:
+- Clone and build on WCOSS
+- Cycled test with workflow with bufr and gempak on
+-->
+
+# Checklist
+- [ ] Any dependent changes have been merged and published
+- [ ] My code follows the style guidelines of this project
+- [ ] I have performed a self-review of my own code
+- [ ] I have commented my code, particularly in hard-to-understand areas
+- [ ] My changes generate no new warnings
+- [ ] New and existing tests pass with my changes
+- [ ] I have made corresponding changes to the documentation if necessary

.github/workflows/linters.yaml

@@ -0,0 +1,37 @@
+#
+name: shellnorms
+on:
+ pull_request:
+
+permissions:
+ contents: read
+
+defaults:
+ run:
+ shell: bash -o pipefail {0}
+
+jobs:
+ lint-shell:
+ runs-on: ubuntu-latest
+
+ permissions:
+ security-events: write
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+
+ - id: ShellCheck
+ name: Lint shell scripts
+ uses: redhat-plumbers-in-action/differential-shellcheck@v4
+ with:
+ token: ${{ secrets.GITHUB_TOKEN }}
+
+ - if: ${{ always() }}
+ name: Upload artifact with ShellCheck defects in SARIF format
+ uses: actions/upload-artifact@v3
+ with:
+ name: Differential ShellCheck SARIF
+ path: ${{ steps.ShellCheck.outputs.sarif }}

.github/workflows/pynorms.yaml

@@ -0,0 +1,24 @@
+name: pynorms
+on: [push, pull_request]
+
+jobs:
+ check_norms:
+ runs-on: ubuntu-latest
+ name: Check Python coding norms with pycodestyle
+
+ steps:
+
+ - name: Install dependencies
+ run: |
+ pip install --upgrade pip
+ pip install pycodestyle
+
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ path: gfs-utils
+
+ - name: Run pycodestyle
+ run: |
+ cd $GITHUB_WORKSPACE/gfs-utils
+ pycodestyle -v --config ./.pycodestyle ./

modulefiles/gfsutils_hera.intel.lua

@@ -15,7 +15,7 @@ load(pathJoin("cmake", cmake_ver))
 load("gfsutils_common")
 
 local gempak_ver=os.getenv("gempak_ver") or "7.4.2"
-load(pathJoin("gempak", gempak_ver))
+-- load(pathJoin("gempak", gempak_ver))
 
 -- Used in rdbfmsua.f
 setenv("gfortran_ROOT", "/apps/gnu/gcc-9.2.0")

modulefiles/gfsutils_orion.intel.lua

@@ -15,7 +15,7 @@ load(pathJoin("cmake", cmake_ver))
 load("gfsutils_common")
 
 local gempak_ver=os.getenv("gempak_ver") or "7.5.1"
-load(pathJoin("gempak", gempak_ver))
+-- load(pathJoin("gempak", gempak_ver))
 
 -- Used in rdbfmsua.f
 setenv("gfortran_ROOT", "/apps/gcc-8/gcc-8.3.0")

modulefiles/gfsutils_wcoss2.intel.lua

@@ -50,7 +50,7 @@ load(pathJoin("nemsio", nemsio_ver))
 load(pathJoin("wrf_io", wrf_io_ver))
 load(pathJoin("g2", g2_ver))
 load(pathJoin("landsfcutil", landsfcutil_ver))
-load(pathJoin("gempak", gempak_ver))
+-- load(pathJoin("gempak", gempak_ver))
 load(pathJoin("wgrib2", wgrib2_ver))
 
 -- Used in rdbfmsua.f