Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variable rescaling for aerosol species #1339

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Add variable rescaling for aerosol species #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94160f8
Changes to chem_diagb.h to allow for variable rescaling for different…
andytangborn Oct 18, 2024
18de78f
Added read for global rescaling file in chem_diagb.h
andytangborn Oct 21, 2024
43a68a8
Merge branch 'develop' into feature/variable_aero_rs
andytangborn Oct 21, 2024
6e5a6cc
Initial try for global rescaling field in chem_diagb.h
andytangborn Oct 21, 2024
5ad73a4
Updated chem_diagb.h and aero_diagb.yaml.j2 to read in rescale file a…
andytangborn Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion parm/aero/berror/aero_diagb.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ variables:
- mass_fraction_of_sea_salt003_in_air
- mass_fraction_of_sea_salt004_in_air

rescale: {{ aero_diagb_rescale }} # rescales the filtered std. dev. by "rescale"
global rescale:
filetype: fms restart
dateapath: ./stddev
filename_trcr: rescale.fv_tracer.res.nc
filename_cplr: rescale.coupler.res

number of halo points: {{ aero_diagb_n_halo }}
number of neighbors: {{ aero_diagb_n_neighbors }}
simple smoothing:
Expand Down
22 changes: 17 additions & 5 deletions utils/chem/chem_diagb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ namespace gdasapp {
oops::Log::info() << "Background:" << std::endl;
oops::Log::info() << xb << std::endl;

/// Read the global rescale
//--------------------------
oops::Log::info() << "=================== read global rescale" << std::endl;
fv3jedi::

/// Create the mesh connectivity (Copy/paste of Francois's stuff)
// --------------------------------------------------------------
// Build edges, then connections between nodes and edges
Expand Down Expand Up @@ -230,13 +235,20 @@ namespace gdasapp {
}
}

// Rescale
if (fullConfig.has("rescale")) {
double rescale;
fullConfig.get("rescale", rescale);
util::multiplyFieldSet(bkgErrFs, rescale);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using multiplyFieldSets? I think this would require creating a 3D array of values in a new field set, but that would then set us up for the ability to scale by height/latitude/location at a later date. Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look at it and see how that would work. It took me some time to make something that could run....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try multiplyFieldSets, but had trouble getting it to compile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we just read in another 'state' that is the scaling factors and be proactive on the 3D front?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So have a file with the scaling factors, and read it in from there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, that way we can easily scale by lat,lon,height and species

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think I understand. A full background state file, filled with rescaling values for each aerosol species and at all locations. I'd like to try just 14 values first and see if we can do better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah they can be constant in x,y,z to start

// Rescale
if (fullConfig.has("global rescale")) {
fv3jedi::State global_rescale(geom, chemVars);
const eckit::LocalConfiguration GlobalRescaleConfig(fullConfig, "global rescale");
global_rescale.read(GlobalRescaleConfig);
atlas::FieldSet grsFs;
global_rescale.toFieldSet(xrsFs);
oops::Log::info() << "global rescaling coefficients:" << std::endl;
oops::Log::info() << grsFs << std::endl;
util::multiplyFieldSets(bkgErrFS, xrsFs)
}



bkgErr.fromFieldSet(bkgErrFs);

// Hybrid B option
Expand Down
Loading