-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/b2i tropical #1311
Feature/b2i tropical #1311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from minor comments
I agree with Andy: I just have some minor comments, otherwise it looks good to me |
Automated Global-Workflow GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And once again @givelberg , your ctests are not triggered. When somebody builds the gdasapp, your tests should be part of the default list, at least on hera and hercules/orion.
@givelberg , your branch is behind develop. Let us know here when this is ready to review. |
@guillaumevernieres I think this is updated now. |
I'm going to merge this and deal with the consequences later ... |
Two converters added to the previous 6 bufr to ioda converters:
drifters and tropical moorings.
Both are taken from the dbuoy bufr input file.
There is also a small bug correction in the cmake file.