feat(communities): announcements don't ask again #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show loading indicator for announcements when submitting, and hide when transaction is finished
…into feat/community-announcements-dontaskagain
|
@Megha-Dev-19 The reason for the proposals lagging is the effects having the dependency to getting all the proposals data. I've fixed one of them, but we need to find another solution for the linked proposals list. |
…into feat/community-announcements-dontaskagain
only indexer feed update is supported fallback to social index is not supported
…eed for social index
petersalomonsen
requested review from
Megha-Dev-19,
Tguntenaar and
ailisp
as code owners
Tguntenaar
approved these changes
Apr 3, 2024
…oes not work with indexer fallback yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview environment:
https://near.social/devgovgigs.petersalomonsen.near/widget/app
show loading indicator for announcements when submitting, and hide when transaction is finished.
Note that the loading indicator stops spinning before the feed is updated. It is possible to make it spin until the feed is updated if we drop the fallback to
Social.index, but I'm not sure how critical this is.announcement.mp4
part of resolving #687