Update 2i2c access management #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ateucher this is great. I fully understood the flows. Beyond minor text suggestions, I left one comment for you and Julie to consider re: harmonize Team & repo names for Champions.
Co-authored-by: Stefanie Butland <[email protected]>
|
Thanks so much @stefaniebutland for the review! |
|
I've created an issue from the outstanding comment from @stefaniebutland. @jules32 do you want to review this as well, or if Stef is happy with it can she approve and merge? |
jules32
approved these changes
May 28, 2024
Co-authored-by: Julia Stewart Lowndes <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for a review now. There is still a bit of an awkward step between the google sheet of form responses and adding to the team, as the form doesn't record the exact name of the team to which they should be added (if it is a workshop or cohort). So we must use context (date form filled out and access type specified) to infer it. It's probably fine, but could possible be addressed on the form side...