Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simple python example #9

Merged
merged 15 commits into from
Jun 7, 2024
Merged

docs: Simple python example #9

merged 15 commits into from
Jun 7, 2024

Conversation

gdanezis
Copy link
Contributor

@gdanezis gdanezis commented Jun 5, 2024

A simple python example using requests to upload and then download a file.

Copy link
Contributor

@karlwuest karlwuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice short example!
One additional suggestion:
Even though there's only one non-std requirement, it would be nice to provide a requirements.txt or a poetry pyproject.toml or to at least put the pip install in the prerequisites.

examples/python/hello_walrus.py Outdated Show resolved Hide resolved
@gdanezis gdanezis mentioned this pull request Jun 6, 2024
2 tasks
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gdanezis, this works well with the latest version of Walrus.

Just a few minor suggestions.

examples/CONFIG/config_dir/client_config.yaml Show resolved Hide resolved
examples/python/hello_walrus_jsonapi.py Outdated Show resolved Hide resolved
examples/python/hello_walrus_jsonapi.py Show resolved Hide resolved
examples/python/hello_walrus_webapi.py Outdated Show resolved Hide resolved
examples/python/hello_walrus_webapi.py Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@gdanezis gdanezis merged commit 5a120d2 into main Jun 7, 2024
5 checks passed
@gdanezis gdanezis deleted the python-hello-world branch June 7, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants