-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sui-benchmark] Add expected failure payloads #19831
Open
williampsmith
wants to merge
4
commits into
main
Choose a base branch
from
william/failure-payloads-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+659
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 22, 2024 00:53
df99e48
to
4cd5965
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 22, 2024 21:18
f8d05bc
to
4c19d70
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
2 times, most recently
from
October 22, 2024 21:46
f6f89da
to
68bfc97
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 22, 2024 21:59
68bfc97
to
bdeed2f
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 23, 2024 20:06
bdeed2f
to
e6222a0
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 24, 2024 22:45
e6222a0
to
0d55362
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 24, 2024 23:28
0d55362
to
af7a1bd
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 25, 2024 04:45
af7a1bd
to
9049d09
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 25, 2024 22:42
055c826
to
5a855a4
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 25, 2024 23:18
5a855a4
to
877e040
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 25, 2024 23:21
877e040
to
11304a2
Compare
williampsmith
force-pushed
the
william/failure-payloads-2
branch
from
October 25, 2024 23:35
11304a2
to
9016407
Compare
mwtian
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm on a high level and let's wait for @arun-koshy to take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new payload type into the benchmark tool -
ExpectedFailurePayload
.This payload type is configured with some expected failure type (currently only one implemented - user signature failure - but others can be added with minimal scaffolding) such that
payload.make_transaction()
generates a transaction that will fail in this manner. Note that the failures that this payload type is concerned with are failures to execute the transaction itself, rather than during execution by the MoveVM. In other words, it is expected that the failure mode will not consume gas or produce effects.Note that for this reason, its failure mode is inverted. It will be tallied for metrics purposes as an
error
if it succeeds and tallied as anexpected_error
(which is a success) if it fails.Also note that transaction responses for this type are handled by producing a
NextOp::Retry
(with some additional logging/metrics) since it is functionally equivalent to a retryable error.Test plan
Ran the following:
Observed the following in logs
Will later run in private testnet.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.