[TrafficController] correctly categorize spam #18324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
williampsmith
force-pushed
the
william/spam-counting
branch
from
2ecefc4
to
aeb24ff
Compare
mystenmark
reviewed
Jun 21, 2024
| } | ||
| Err(err) => { | ||
| Err(err) | ||
| } |
There was a problem hiding this comment.
this could just be .map(|(result, _)| result)
| if !policy_config.spam_sample_rate.is_sampled().await { | ||
| let sampled = futures::future::join_all(vec
williampsmith
force-pushed
the
william/spam-counting
branch
from
72bab95
to
b4a59bf
Compare
williampsmith
added a commit
that referenced
this pull request
Jun 27, 2024
## Description This PR redefines spam in the context of traffic controller as any request type that does not consume gas. There are two such categories that have bee considered so far - read api requests and transaction execution requests that do not invoke the vm (which, to my knowledge, should only happen on submitting a certificate for an already executed transaction, at which point all validators simply read and return the effects). Both cases are hadled here. ## Test plan Fixed existing tests to exercise the new logic --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
williampsmith
added a commit
that referenced
this pull request
Jun 27, 2024
## Description CP #18396 and #18324 ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
## Description This PR redefines spam in the context of traffic controller as any request type that does not consume gas. There are two such categories that have bee considered so far - read api requests and transaction execution requests that do not invoke the vm (which, to my knowledge, should only happen on submitting a certificate for an already executed transaction, at which point all validators simply read and return the effects). Both cases are hadled here. ## Test plan Fixed existing tests to exercise the new logic --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR redefines spam in the context of traffic controller as any request type that does not consume gas. There are two such categories that have bee considered so far - read api requests and transaction execution requests that do not invoke the vm (which, to my knowledge, should only happen on submitting a certificate for an already executed transaction, at which point all validators simply read and return the effects). Both cases are hadled here.
Test plan
Fixed existing tests to exercise the new logic
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.